[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 18 14:27:07 PST 2019


arphaman added a comment.

In D56892#1363089 <https://reviews.llvm.org/D56892#1363089>, @aaron.ballman wrote:

> I think the documentation for the attribute should be updated to explain this new behavior, otherwise this will be a very inexplicable feature to users.


Done

> One question I have is: will this feature also be needed by other attributes? This seems like a somewhat general problem between explicit attributes, implicit attributes, and attributes added via the pragma. It might not be worth generalizing yet, but I'm curious to know whether we'll need this for things like visibility and type_visibility as well.

Possibly. We haven't come across a use case that requires that yet, but we would be definitely willing to work on a more generalized solution in the future if such a need arises.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56892/new/

https://reviews.llvm.org/D56892





More information about the cfe-commits mailing list