[PATCH] D56610: [clangd] A code action to qualify an unqualified name

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 18 10:46:52 PST 2019


JonasToth added a comment.

In D56610#1363461 <https://reviews.llvm.org/D56610#1363461>, @ilya-biryukov wrote:

> In D56610#1363408 <https://reviews.llvm.org/D56610#1363408>, @JonasToth wrote:
>
> > Is this for something like `add const`? 
> >  If yes, there is clang-tidy effort on that, see https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a similar effort. Would be best to share the code instead of reinventing it :)
>
>
> No, this action is not about adding a type qualifier (like `const` or `volatile`), it adds a namespace qualifier, e.g.
>
>   using namespace std;
>  
>   vector<int> foo; // --> std::vector<int> foo;
>
>
> Moreover, it's just an example to illustrate how one could write a simple action like that in clangd.


I see, nvmd then :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56610/new/

https://reviews.llvm.org/D56610





More information about the cfe-commits mailing list