[PATCH] D56267: [clangd] Interfaces for writing code actions

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/ClangdServer.cpp:339
+      return CB(llvm::createStringError(llvm::inconvertibleErrorCode(),
+                                        "could not create action context"));
+    CB(prepareTweaks(*Inputs));
----------------
(action context?)


================
Comment at: clangd/ClangdServer.cpp:363
+      return CB(A.takeError());
+    return CB((*A)->apply(*Inputs));
+  };
----------------
we should `format::cleanUpAroundReplacements`... fine to leave this as a FIXME


================
Comment at: clangd/refactor/Tweak.h:45
+    /// The path of an active document the action was invoked in.
+    llvm::StringRef File;
+    /// The text of the active document.
----------------
Hmm, maybe we should drop this until we know how cross-file tweaks will work?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56267/new/

https://reviews.llvm.org/D56267