[PATCH] D56829: Move decl context dumping to TextNodeDumper

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 18 07:07:14 PST 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from the testing situation -- so long as the tests come out without changes, this is good to go. If there is a change in test behavior, let's do another round of review just to verify everyone's happy with the behavioral change.



================
Comment at: lib/AST/ASTDumper.cpp:1232
 
-  if (D->isThisDeclarationADefinition()) {
+  if (D->isThisDeclarationADefinition())
     dumpDeclContext(D);
----------------
Since this is just formatting changes unrelated to the patch, feel free to revert and commit separately for commit hygiene.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56829/new/

https://reviews.llvm.org/D56829





More information about the cfe-commits mailing list