[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

just a few nits



================
Comment at: clangd/GlobalCompilationDatabase.cpp:23
+
+void AdjustArguments(tooling::CompileCommand &Cmd,
+                     const std::string &ResourceDir) {
----------------
naming NIT: use `adjustArguments`


================
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+                     const std::string &ResourceDir) {
+  // Strip plugin related command line arguments. Clangd does
----------------
NIT: use `StringRef`


================
Comment at: clangd/GlobalCompilationDatabase.cpp:136
+    : Base(Base),
+      ResourceDir(ResourceDir ? *ResourceDir : getStandardResourceDir()),
+      FallbackFlags(std::move(FallbackFlags)) {
----------------
NIT: avoid an unnecessary copy: `ResourceDir ? std::move(*ResourceDir) : …`


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56841/new/

https://reviews.llvm.org/D56841