[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 17 22:36:50 PST 2019


rjmccall added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:9839
+    return Success(Result, E);
+  }
+
----------------
Can most of this reasonably be a method on `APFixedPoint`?  (And likewise for `CK_IntegralToFixedPoint`.)  If nothing else, I suspect you are going to want these when it comes to things like the compound assignment operators, which do implicit conversions internally that aren't directly expressed in the AST.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56900/new/

https://reviews.llvm.org/D56900





More information about the cfe-commits mailing list