[PATCH] D56868: Add -fset-visibility-for-decls for -cc1

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 17 14:29:52 PST 2019


rjmccall added inline comments.


================
Comment at: include/clang/Driver/CC1Options.td:707
+def fset_visibility_for_decls : Flag<["-"], "fset-visibility-for-decls">,
+  HelpText<"Apply global symbol visibility to declarations without an explicit visibility">;
 def ftemplate_depth : Separate<["-"], "ftemplate-depth">,
----------------
"Declaration" doesn't unambiguously mean "non-definition" in language parlance;
maybe something like "external declaration" in both help text and the option name?
So maybe `-fextern-visibility`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56868/new/

https://reviews.llvm.org/D56868





More information about the cfe-commits mailing list