[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

While you're here, can you also fix `__builtin_arm_rbit64`, `__builtin_arm_rsr64`, and `__builtin_arm_wsr64`?



================
Comment at: include/clang/Basic/BuiltinsAArch64.def:54
+BUILTIN(__builtin_arm_crc32d, "UiUiLLUi", "nc")
+BUILTIN(__builtin_arm_crc32cd, "UiUiLLUi", "nc")
 
----------------
rnk wrote:
> If we can't change the signature on Linux (I don't see any reason why couldn't, though) we can use the 'W' builtin code to indicate that it's `long` on LP64 and `long long` on LLP64.
Changing the signature would be fine, I think (we don't expect people to use these directly, and even if they did it wouldn't make any practical difference outside of obscure edge cases).  But probably better to match the ACLE signature for the sake of clarity.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56852/new/

https://reviews.llvm.org/D56852