[PATCH] D56841: [clangd] Filter out plugin related flags.
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 17 06:38:01 PST 2019
klimek added a comment.
In D56841#1361395 <https://reviews.llvm.org/D56841#1361395>, @kadircet wrote:
> It seems like the most relevant place in tooling is ArgumentsAdjuster as @ioeric pointed out. Happy to move it to there if @sammccall and @klimek agrees as well.
>
> As a side note `ArgumentsAdjuster`s unfortunately causes a copy of the original command line arguments. Not sure how important this factor is compared to spinning up a compiler instance, just wanted to point it out.
>From my point of view, it looks like this isn't enough to be a huge thing in tooling. That said, if we can find a nice abstraction to pull out, I'm generally in favor :) (I know, I know, I'm not a big help)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56841/new/
https://reviews.llvm.org/D56841
More information about the cfe-commits
mailing list