[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 16 09:17:00 PST 2019


Anastasia marked 2 inline comments as done.
Anastasia added inline comments.


================
Comment at: lib/CodeGen/CGCall.cpp:78
+    RecTy = Context.getAddrSpaceQualType(
+        RecTy, MD->getTypeQualifiers().getAddressSpace());
   return Context.getPointerType(CanQualType::CreateUnsafe(RecTy));
----------------
Anastasia wrote:
> rjmccall wrote:
> > Would you mind making a patch to rename this (and the method on `FunctionProtoType`) to something like `getMethodQualifiers`?  It can be a follow-up instead of blocking this.
> Sure. I will prepare a separate patch for this.
FYI, covered by: https://reviews.llvm.org/D56792


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56066/new/

https://reviews.llvm.org/D56066





More information about the cfe-commits mailing list