[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

One nit-pick, then this is good to go.



================
Comment at: clang/include/clang/AST/APValue.h:183
+    setFixedPoint(std::move(FX));
+  }
   explicit APValue(const APValue *E, unsigned N) : Kind(Uninitialized) {
----------------
I know this is the established pattern, but could you just make `MakeFixedPoint` take a `APFixedPoint &&` and move it into place instead of default-constructing one and then assigning over it?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56746/new/

https://reviews.llvm.org/D56746