[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

Peter Collingbourne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 15 14:51:30 PST 2019


pcc added inline comments.
Herald added a subscriber: llvm-commits.


================
Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814
+bool Linux::isPIEDefault() const {
+  return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) ||
+         getSanitizerArgs().requiresPIE();
----------------
Why only on API level >= 16? If I create an executable targeting an older API level, it should still work on higher API levels.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D38430/new/

https://reviews.llvm.org/D38430





More information about the cfe-commits mailing list