[PATCH] D56658: [MSP430] Add msp430 toochain

Tue Jan 15 13:32:05 PST 2019

nathanchance marked an inline comment as done.
nathanchance added inline comments.

================
Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141
+      (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) {
+    fprintf(stderr, "TBAA enabled\n");
     TBAA.reset(new CodeGenTBAA(Context, TheModule, CodeGenOpts, getLangOpts(),
----------------
asl wrote:
> nathanchance wrote:
> > I'm just curious, was committing this change intentional? Seems like something for debugging purposes, rather than a useful diagnostic, since it doesn't appear to be related to the rest of the patch (as far as I can tell).
> > 
> > I see it quite a bit on a Linux kernel build: https://gist.github.com/nathanchance/0b2d3b199996d5b30396038d86f5cba3
> Oh... Sorry, maybe unclean tree or something like this. Will fix!
Thanks for the quick reply, looks like Peter Collingbourne beat you to it :) https://reviews.llvm.org/rC351241

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56658/new/

https://reviews.llvm.org/D56658