[PATCH] D56429: fix python3 compability issue

Jakub Stasiak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 15 02:15:12 PST 2019


jstasiak marked an inline comment as done.
jstasiak added inline comments.


================
Comment at: bindings/python/clang/cindex.py:3001
+                contents = b(contents)
+                unsaved_files_array[i].name = b(fspath(name))
+                unsaved_files_array[i].contents = contents
----------------
Nitpicking: the description only mentions changes related to file contents but this modification (`fspath(name)` -> `b(fspath(name))`) likely fixes a different issue, it may be worth mentioning this in the commit message. Unless this extra `b()` call is not strictly necessary here but added for consistency?



Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56429/new/

https://reviews.llvm.org/D56429





More information about the cfe-commits mailing list