[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

In D55433#1351707 <https://reviews.llvm.org/D55433#1351707>, @JonasToth wrote:

> > I do not have commit rights. I'm not sure what constitutes someone who can commit, but let me contribute a little more before taking that step,  I have another idea for a checker I'd like to try after this one, I just wanted to get one under my belt first.
>
> See this: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
>
> I will commit for you then. More patches always welcome ;)


@JonasToth, I notice when you commit you commit in 2 places, is this by hand or automatic? or if this process is mandated or written down somewhere?

rCTE350760 <https://reviews.llvm.org/rCTE350760>: [clang-tidy] Adding a new modernize use nodiscard checker
rL350760 <https://reviews.llvm.org/rL350760>: [clang-tidy] Adding a new modernize use nodiscard checker

Do you have any guidance on how YOU commit (especially in clang-tools-extra) that might be useful to others just starting out?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433