[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 15 00:12:09 PST 2019
lebedev.ri added a comment.
In D56424#1357471 <https://reviews.llvm.org/D56424#1357471>, @MyDeveloperDay wrote:
> In D56424#1356959 <https://reviews.llvm.org/D56424#1356959>, @karepker wrote:
>
> > Hi all, ping on this patch. I've addressed all comments to the best of my ability. Is there anything outstanding that needs to be changed?
>
>
> Round about this time of a review we normally hear @JonasToth asking if you've run this on a large C++ code base like LLVM (with fix-its), and seen if the project still builds afterwards..might be worth doing that ahead of time if you haven't done so already
>From docs: `This check does not propose any fixes.`.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56424/new/
https://reviews.llvm.org/D56424
More information about the cfe-commits
mailing list