[PATCH] D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews

Casey Carter via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 14 10:25:45 PST 2019


CaseyCarter added a comment.

In D53763#1356356 <https://reviews.llvm.org/D53763#1356356>, @mclow.lists wrote:

> I'm a bit concerned about the `TEST_HAS_NO_SPACESHIP_OPERATOR` and how it tracks with `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`, but I'm not going to hold this up for that.


Same. I tried to convince the compiler guys to define a feature-test macro, but they're paranoid about doing so before it's in the standard. We can clean this up when that happens.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53763/new/

https://reviews.llvm.org/D53763





More information about the cfe-commits mailing list