[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 14 10:16:13 PST 2019


Eugene.Zelenko added a comment.

In D54945#1355920 <https://reviews.llvm.org/D54945#1355920>, @MarinaKalashina wrote:

> @Eugene.Zelenko
>
> > I would suggest to rename contribution to Contributing (see LLVM documentation) and integrations to Integrations.
>
> Sure, done.
>
> > Will be also good idea to fix D55523 <https://reviews.llvm.org/D55523> script warnings.
>
> The script warns about double spaces and line width in the table, for example:
>
>   warning: line 39 contains double spaces
>   warning: line 39 is in excess of 80 characters (196)
>
>
> These spaces and width are intended since they 'draw' the table layout. Do you think we could ignore such warnings in this particular case?


Sure, it's fine to leave table as it is. Same thing is done in LLDB code where tables are excluded from Clang-format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54945/new/

https://reviews.llvm.org/D54945





More information about the cfe-commits mailing list