[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 14 07:10:49 PST 2019


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: ELF/Driver.cpp:757
+  if (!TargetOpt.empty()) {
+    // TODO: do we want to verify it and fail on unsupported?
+    Config->TargetTriple = llvm::Triple(TargetOpt);
----------------
arichardson wrote:
> I think failing on an unknown triple would be good since it can avoid user error where the wrong defaults are chosen just because of a small typo.
Somewhat done. Note that LLD apparently doesn't fail on errors immediately, so it behaves a bit weird.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56650/new/

https://reviews.llvm.org/D56650





More information about the cfe-commits mailing list