[PATCH] D56429: fix python3 compability issue
serge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 14 00:35:25 PST 2019
serge-sans-paille added inline comments.
================
Comment at: bindings/python/clang/cindex.py:2998
+ for i,(name,contents) in enumerate(unsaved_files):
+ if hasattr(contents, "read"):
+ contents = contents.read()
----------------
serge-sans-paille wrote:
> Why did you remove the FIXME comment?
@roxma LGTM except this FIXME removal.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56429/new/
https://reviews.llvm.org/D56429
More information about the cfe-commits
mailing list