[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Dmitry Venikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 13 03:12:11 PST 2019


Quolyk marked an inline comment as done.
Quolyk added inline comments.


================
Comment at: test/clang-tidy/readability-container-size-empty.cpp:19-20
   basic_string<T> operator+(const basic_string<T>& other) const;
   unsigned long size() const;
+  unsigned long length() const;
   bool empty() const;
----------------
lebedev.ri wrote:
> Does it still work if only one of these exists?
It works indeed, do you suggest adding test case for this?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56644/new/

https://reviews.llvm.org/D56644





More information about the cfe-commits mailing list