[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Dmitry Venikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 12 23:34:12 PST 2019


Quolyk added a comment.

For now, I just added tests. I have several questions, as I'm beginner (`ContainerSizeEmptyCheck.cpp`).

1. Do I have to extend `ValidContainer`, so it recognises `::std::string` with `length()` method  as valid container too or we can assume `::std::string` as valid container by default?
2. If `::std::string` is valid container, I just add one more expression to match. Is it correct way?




Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56644/new/

https://reviews.llvm.org/D56644





More information about the cfe-commits mailing list