[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 12 05:05:30 PST 2019


steveire added a comment.

In D55491#1355105 <https://reviews.llvm.org/D55491#1355105>, @thakis wrote:

> Out of interest, what's the motivation for this? It seems to add way more code than it removes, so there must be some other advantage, but the patch description doesn't say.


The reason for this is to split the output streaming from the traversal to other AST nodes.

This is a step as part of a larger refactoring with the aim of a class extracted from ASTDumper which does traversal but no streaming. That way, we can dump other output formats and do other things with the traversal.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55491/new/

https://reviews.llvm.org/D55491





More information about the cfe-commits mailing list