[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 11 18:10:55 PST 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from nits that aren't complete yet, LGTM.



================
Comment at: include/clang/AST/TemplateArgumentVisitor.h:24
+/// A simple visitor class that helps create template argument visitors.
+template <template <typename> class Ref, typename ImplClass,
+          typename RetTy = void, typename... ParamTys>
----------------
Missed a `typename` in there.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55491/new/

https://reviews.llvm.org/D55491





More information about the cfe-commits mailing list