[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

Tom Tan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 11 17:15:48 PST 2019


TomTan added a comment.

We need full definition for __nop in intrin.h.



================
Comment at: lib/Headers/intrin.h:569
+unsigned __int64 _byteswap_uint64 (unsigned __int64 val);
+void __nop();
 #endif
----------------
efriedma wrote:
> Isn't there already a declaration of __nop in intrin.h?  (Line 100.)
For __nop, we probably need full definition instead of declaration, just like __nop for x86/x64 in this file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56620/new/

https://reviews.llvm.org/D56620





More information about the cfe-commits mailing list