[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map
    Peter Wu via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Fri Jan 11 16:04:31 PST 2019
    
    
  
Lekensteyn added a comment.
Except one thing, it looks reasonable to me. I'll try to run some tests and report back tomorrow.
(Not very familiar with Phabricator either. I still see some comments, hopefully the "Collapse" function does something useful here.)
================
Comment at: test/Driver/prefix-map.S:7
+
+// More tests for this flag in debug-prefix-map.c.
----------------
Maybe restore the old file name (debug-prefix-map.S) since this still tests the debug prefix functionality? And otherwise this comment needs to be updated.
Repository:
  rC Clang
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49466/new/
https://reviews.llvm.org/D49466
    
    
More information about the cfe-commits
mailing list