[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: lib/Sema/SemaStmtAsm.cpp:470
+    if (NS->isGCCAsmGoto() &&
+        Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass)
+      break;
----------------
jyu2 wrote:
> efriedma wrote:
> > This looks suspicious; an AddrLabelExpr could be an input or output, e.g. `"r"(&&foo)`.
> Syntax for asm goto:
>  Syntax:
>    asm [volatile] goto ( AssemblerTemplate
>                        :
>                        : InputOperands
>                        : Clobbers
>                        : GotoLabels)
> 
>  Only input is allowed.  Output is not allowed
> 
That doesn't really address my point here... ignore the "or output" part of the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56571/new/

https://reviews.llvm.org/D56571