[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver
Joerg Sonnenberger via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 11 05:57:38 PST 2019
joerg added inline comments.
================
Comment at: ELF/Driver.cpp:779
+ // TODO: verify the triple somehow?
+ Config->TargetTriple = llvm::Triple(Prefix);
+ }
----------------
mgorny wrote:
> joerg wrote:
> > See ToolChain::getTargetAndModeFromProgramName in clang.
> Yes, I've based this on stripped down version of that. Most notably, I wasn't able to verify triple against TargetRegistry since it isn't initialized here.
initLLVM is called too late. That should be all that is needed to do a proper look up.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56215/new/
https://reviews.llvm.org/D56215
More information about the cfe-commits
mailing list