[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 11 05:56:46 PST 2019


Anastasia marked 6 inline comments as done.
Anastasia added inline comments.


================
Comment at: lib/CodeGen/CGExprAgg.cpp:813
+  case CK_AddressSpaceConversion: {
+    Visit(E->getSubExpr());
+    break;
----------------
rjmccall wrote:
> If there's a `Dest`, you might need to reverse-convert its address space, right?
After I fixed the AST (by setting VK correctly on ICE) we are no longer hitting this path. So I removed the unnecessary changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56066/new/

https://reviews.llvm.org/D56066





More information about the cfe-commits mailing list