[PATCH] D56555: Add Attribute to define nonlazy objc classes

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

The patch is missing SemaObjC tests that ensure the attribute only appertains to the expected subjects, accepts no args, etc.



================
Comment at: clang/include/clang/Basic/Attr.td:1696
+  let Subjects = SubjectList<[ObjCInterface], ErrorDiag>;
+  let Documentation = [Undocumented];
+}
----------------
No new undocumented attributes, please.

Does this attribute make sense when compiling a non-ObjC compiland? e.g., should this also have a `let LangOpts = [ObjC];` as well?


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6377-6379
+  case ParsedAttr::AT_ObjCNonLazyClass:
+      handleSimpleAttribute<ObjCNonLazyClassAttr>(S, D, AL);
+      break;
----------------
Formatting is incorrect here -- you should run the patch through clang-format.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56555/new/

https://reviews.llvm.org/D56555