[PATCH] D55492: Implement Attr dumping in terms of visitors

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lib/AST/ASTDumper.cpp:89
     // Utilities
-    void dumpType(QualType T) { NodeDumper.dumpType(T); }
     void dumpTypeAsChild(QualType T);
----------------
steveire wrote:
> aaron.ballman wrote:
> > This seems unrelated to this patch (same below) ?
> These were called from the code which tablegen used to generate for dumping attrs. They're no longer needed after this change.
Ah, thank you for the explanation!


================
Comment at: lib/AST/TextNodeDumper.cpp:44-45
 
+void TextNodeDumper::Visit(const Attr *A) {
+  {
+    ColorScope Color(OS, ShowColors, AttrColor);
----------------
steveire wrote:
> aaron.ballman wrote:
> > Formatting is incorrect.
> Note that this is a scope for the color, not the opening of the function.
Yup, my eyes glazed right over that.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55492/new/

https://reviews.llvm.org/D55492