[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

Thu Jan 10 13:25:43 PST 2019

JonasToth added a comment.

In D56444#1353003 <https://reviews.llvm.org/D56444#1353003>, @sammccall wrote:

> In D56444#1351714 <https://reviews.llvm.org/D56444#1351714>, @JonasToth wrote:
>
> > @sammccall I (hopefully) fixed the type-issue in my test-cases. They nevertheless fail both on me, on latest llvm+clang+your patch. Clang-tidy still the same, so maybe there is a difference in our builds?
> >  Do you build with assertions on?
> >  I work on linux, ubuntu 18.04, building with clang-6.0, maybe there is a difference?
>
>
> Your tests indeed fail (I was rebuilding `AnalysisTests` instead of `ClangAnalysisTests`, oops!).
>  The `// namespace std` comments out the rest of the test, because the test contains no newlines. Try using raw strings instead :-)
>  After removing the comments, the tests pass.

Same result! They do crash with the wrong comment. Thats probably the next surprise? :) I will pretend I didn't see anything ;)
Both the tests run and the const-analysis does not crash anymore, too.

Thank you very much for fixing the issue.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56444/new/

https://reviews.llvm.org/D56444