[PATCH] D56523: Improve a -Wunguarded-availability note

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington added inline comments.


================
Comment at: clang/test/Sema/availability-guard-format.mm:6
 @interface foo
-- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been explicitly marked partial here}}
+- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been marked as being introduced in macOS 10.12 here, but the deployment target is macOS 10.4.0}}
 @end
----------------
dexonsmith wrote:
> erik.pilkington wrote:
> > jkorous wrote:
> > > I am probably missing something but where is the deployment target value set?
> > Its set implicitly, but you can also control it with `-mmacos-version-min=` flag.
> Would it be better to set the deployment target explicitly in this test?  Otherwise we're implicitly testing what the default is, which seems orthogonal to what the diagnostic should say.
Yeah, I guess that would make the tests less fragile. This should have been done already, but the triple was wrong. New patch fixes it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56523/new/

https://reviews.llvm.org/D56523