[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

Hyrum Wright via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 10 12:09:14 PST 2019


hwright added inline comments.


================
Comment at: docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:20
+
+
+  // Original - Cast from a double to an integer
----------------
MyDeveloperDay wrote:
> nit: double blank line
This is intentional (and consistent with other examples in other tools).


================
Comment at: docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:28
+
+
+Note: In the second example, the suggested fix could yield a different result,
----------------
MyDeveloperDay wrote:
> nit: double blank line
This is intentional (and consistent with other documentation).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56532/new/

https://reviews.llvm.org/D56532





More information about the cfe-commits mailing list