[PATCH] D56552: [clang-tidy] update FunctionSizeCheck for D56444
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 10 10:08:14 PST 2019
sammccall created this revision.
sammccall added reviewers: JonasToth, aaron.ballman.
Herald added subscribers: cfe-commits, xazax.hun.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D56552
Files:
clang-tidy/readability/FunctionSizeCheck.cpp
Index: clang-tidy/readability/FunctionSizeCheck.cpp
===================================================================
--- clang-tidy/readability/FunctionSizeCheck.cpp
+++ clang-tidy/readability/FunctionSizeCheck.cpp
@@ -145,7 +145,12 @@
}
void FunctionSizeCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(functionDecl(unless(isInstantiated())).bind("func"), this);
+ // Lambdas ignored - historically considered part of enclosing function.
+ // FIXME: include them instead? Top-level lambdas are currently never counted.
+ Finder->addMatcher(functionDecl(unless(isInstantiated()),
+ unless(cxxMethodDecl(ofClass(isLambda()))))
+ .bind("func"),
+ this);
}
void FunctionSizeCheck::check(const MatchFinder::MatchResult &Result) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56552.181082.patch
Type: text/x-patch
Size: 837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190110/68a55602/attachment.bin>
More information about the cfe-commits
mailing list