[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 10 09:33:10 PST 2019


steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: lib/AST/ASTDumper.cpp:449-450
+    void VisitPackTemplateArgument(const TemplateArgument &TA) {
+      for (TemplateArgument::pack_iterator I = TA.pack_begin(),
+                                           E = TA.pack_end();
+           I != E; ++I)
----------------
aaron.ballman wrote:
> `llvm::for_each(TA.pack_elements(), ...);` (or a range-based for loop)
I'm just moving the code as it is in its origin location. You could rewrite it separately if you wish.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55491/new/

https://reviews.llvm.org/D55491





More information about the cfe-commits mailing list