[PATCH] D56318: [HIP] Fix size_t for MSVC environment
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 10 09:29:29 PST 2019
rjmccall added a comment.
If I was only concerned about `size_t`, your current solution would be fine. My concern is that you really need to match *all* of the associated CPU target's ABI choices, so your target really ought to be forwarding everything to that target by default and only selectively overriding it in order to support GPU-specific features. Probably the easiest way to do that is via inheritance.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56318/new/
https://reviews.llvm.org/D56318
More information about the cfe-commits
mailing list