[PATCH] D50106: [libc++] Fix tuple assignment from type derived from a tuple-like

Thu Jan 10 02:53:11 PST 2019

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Our constructors still have the same bug,. Are you planning on fixing those as well? Doing so will require a metric butt-tonne of overloads.
If you're not planning on fixing the constructors, then can you explain why it's better that we're inconsistent?

Otherwises, this patch looks mostly OK. However, it makes a bunch of previously lazy SFINAE eager. Here are some tests:
https://gist.github.com/EricWF/88ceadf2bcdeef9f9d268b3a743dcd04

Is there a reason we can't use `__tuple_assignable` anymore?

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50106/new/

https://reviews.llvm.org/D50106