[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 9 12:01:50 PST 2019


rjmccall added a comment.

I really dislike this particular idiom.

This is probably the most reasonable short-term solution to this problem.  I do wonder if we should just shift to making Sema track a symbol-to-GD map, though, and maybe make Sema entirely responsible for pushing entities to IRGen to emit.



================
Comment at: test/Sema/alias-unused.c:3
+// expected-no-diagnostics
+int f() { return 42; }
+int g() __attribute__((alias("f")));
----------------
Is this meant to be `static`?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54188/new/

https://reviews.llvm.org/D54188





More information about the cfe-commits mailing list