[PATCH] D55781: Make CC mangling conditional on the ABI version

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.
Herald added a subscriber: mstorsjo.

Sorry for not noticing this sooner.  The TL;DR is, the current patch does not affect PS4, so go ahead; but see the long version for other considerations.

First, the general point: The PS4 ABI does not fit neatly into the sequential ClangABI versioning scheme. We forked a while back, and adopted a few subsequent changes and didn't adopt other changes. Just to make everyone's life less boring. And give me migraines. So, whenever ABI-related things happen, we need to be conscious of that (not fitting neatly; my headaches are not a consideration).

Second, IIUC the PS4 ABI ignores all the calling-convention attributes that are handled specially by this patch. So to that degree, PS4 doesn't care.  We don't support the MS-specific ones, in particular.

That said, I've discovered that there are at least a few of these non-target-specific CC attributes that we fail to ignore, such as vectorcall, and there's internal discussion to sort out what to do about that.  None of which should prevent this patch from going forward.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55781/new/

https://reviews.llvm.org/D55781