[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Wed Jan 9 06:54:30 PST 2019

MyDeveloperDay added a comment.

In D55433#1350999 <https://reviews.llvm.org/D55433#1350999>, @JonasToth wrote:

> LGTM!
>  You verified that your fixes, fix the issues in LLVM? But it looks good to go.

They look good, you asked before...

> P.S. did you request commit rights already?

I do not have commit rights. I'm not sure what constitutes someone who can commit, but let me contribute a little more before taking that step,  I have another idea for a checker I'd like to try after this one, I just wanted to get one under my belt first.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433