[PATCH] D56466: [CodeGen] Clarify comment about COFF common symbol alignment

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 8 16:51:47 PST 2019


majnemer added inline comments.


================
Comment at: lib/CodeGen/CodeGenModule.cpp:3765-3766
+
+  // MSVC doesn't support alignments greater than 32 for common symbols, so
+  // symbols with greater alignment requirements cannot be common. Non-MSVC COFF
+  // environments support arbitrary power-of-two alignments for common symbols
----------------
I think it is most clear if this comment said "Microsoft's link.exe" instead of MSVC.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56466/new/

https://reviews.llvm.org/D56466





More information about the cfe-commits mailing list