[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 8 07:59:57 PST 2019


martong added a comment.

Just a quick note. We are pretty sure that `StructuralEquivalency` can have false positive results, i.e. it can report two decls as nonequivalent falsely. My understanding is that we should report an error only if we are absolutely certain that an error has happened, this is not the case with `StructuralEquivalency`. Consequently this should be a warning in Sema (modules) too.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55646/new/

https://reviews.llvm.org/D55646





More information about the cfe-commits mailing list