[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D56442#1349666 <https://reviews.llvm.org/D56442#1349666>, @ilya-biryukov wrote:

> LGTM. Thanks for fixing this.
>
> A few questions for the long-term:
>
> - Should we consider removing the YAML support altogether?


The motivation of the YAML is for debugging purpose (compared with the binary format), we might want to switch to another human-readable format like json.

> - If we want to keep, are there non-private APIs that we could use? (I assume we need them to avoid keeping the whole parsed YAML tree in memory, right?)

This is the best way we've found so far. The public YAML APIs don't seem provide enough flexibility to read an `Variant` element (but I may miss something).


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56442/new/

https://reviews.llvm.org/D56442