[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 8 01:53:41 PST 2019


MyDeveloperDay added inline comments.


================
Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:1
+//===--- AvoidUnderscoreInGoogletestNameCheck.cpp - clang-tidy-------------===//
+//
----------------
nit: space after tidy and before ---


================
Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h:1
+//===--- AvoidUnderscoreInGoogletestNameCheck.h - clang-tidy---------------===//
+//
----------------
nit: I think you may have used an older version of add_new_check.py because the header looks like this now

A gap after the tidy and *- C++ -*

```
//===--- UseNodiscardCheck.h - clang-tidy -----------------------*- C++ -*-===//
```

This could be why the header guard isn't the correct format


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56424/new/

https://reviews.llvm.org/D56424





More information about the cfe-commits mailing list