[PATCH] D56391: Limit COFF 'common' emission to <=32 alignment types.

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 7 12:41:44 PST 2019


majnemer added inline comments.


================
Comment at: lib/CodeGen/CodeGenModule.cpp:3766
+  // in common.
+  if (Context.getTargetInfo().getTriple().isOSBinFormatCOFF() &&
+      Context.getTypeAlignIfKnown(D->getType()) > 32)
----------------
I think this should be isKnownWindowsMSVCEnvironment


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56391/new/

https://reviews.llvm.org/D56391





More information about the cfe-commits mailing list