[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 7 09:50:49 PST 2019


JonasToth added a comment.

In D55433#1347553 <https://reviews.llvm.org/D55433#1347553>, @MyDeveloperDay wrote:

> libprotobuf still builds cleanly with just the one expected warning..despite adding over 500 [[nodiscards]]
>
> F7800873: image.png <https://reviews.llvm.org/F7800873>
>
> I'll continue to look at other projects, but I'm happy at present that this gives us a good starting point.


That looks good. If llvm (significant parts of it) are fine too, ready to go.

P.S. did you request commit rights already?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433





More information about the cfe-commits mailing list