[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 7 05:18:29 PST 2019


riccibruno added a comment.

In D56367#1347845 <https://reviews.llvm.org/D56367#1347845>, @rjmccall wrote:

> Does the regression disappear if you make the scope specifier the first trailing object?  Later trailing objects are more expensive to access, and I would imagine that the scope specifier and template arguments are more important than the other fields.


That was with the scope specifier first. I would imagine that putting it last would be indeed be more expensive.
I can leave a TODO here saying that it could be in principle be stored as a trailing object, but the that the run-time effect
of doing so should be investigated.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56367/new/

https://reviews.llvm.org/D56367





More information about the cfe-commits mailing list