[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 7 03:39:17 PST 2019
ilya-biryukov added a comment.
@hokein, do you need reviewers for this? I'm happy to volunteer.
In D56314#1347511 <https://reviews.llvm.org/D56314#1347511>, @nridge wrote:
> Might we want to keep some of this information for `workspace/symbol`? I mean, surely not "documentation", but perhaps "signature" and "return type"?
There's nothing stopping us from reintroducing this information if we start doing the same. I don't foresee difficulties with this. It would be easier to figure out the bits we actually need when we implement this functionality.
But I generally prefer to move fast and fix things as you go, even if that means going back and forth, others might disagree.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56314/new/
https://reviews.llvm.org/D56314
More information about the cfe-commits
mailing list