[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 5 19:38:42 PST 2019


nridge added a comment.

Might we want to keep some of this information for `workspace/symbol`? I mean, surely not "documentation", but perhaps "signature" and "return type"?

For example, when cquery responds to `workspace/symbol`, it puts into `SymbolInformation.name` a "detailed name" <https://github.com/cquery-project/cquery/blob/70c755b2e390d3edfb594a84a7531beb26b2bc07/src/query_utils.cc#L304> that includes the return type and signature for functions, allowing clients to display these in their "Open Element" dropdown. This is in turn useful for e.g. selecting the correct one among multiple overloads of a function to jump to.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56314/new/

https://reviews.llvm.org/D56314





More information about the cfe-commits mailing list